Add instructions on how to build to the README.#187
Open
camilasan wants to merge 2 commits intolinuxdeploy:masterfrom
Open
Add instructions on how to build to the README.#187camilasan wants to merge 2 commits intolinuxdeploy:masterfrom
camilasan wants to merge 2 commits intolinuxdeploy:masterfrom
Conversation
c5af6e1 to
3c358b6
Compare
3c358b6 to
36b6d82
Compare
Contributor
Author
|
@TheAssassin my PR is not valid? Should I close it? |
36b6d82 to
37d273a
Compare
bjorn
reviewed
Feb 24, 2025
Contributor
bjorn
left a comment
There was a problem hiding this comment.
Just leaving some comments. I have not verified the instructions.
| - [patchelf](https://github.com/NixOS/patchelf) | ||
| - [cimg](https://cimg.eu/) | ||
| - optional - disable it with `USE_CCACHE` cmake var: [ccache](https://ccache.dev/) | ||
| 2. [Fork this repository and clone it](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo). |
Contributor
There was a problem hiding this comment.
Why would you suggest to fork the repository just to build it?
Contributor
Author
There was a problem hiding this comment.
Why would you suggest to fork the repository just to build it?
If you want to contribute to the project, that is how you do it.
Only people with access to the repo don't need to fork.
Contributor
Author
There was a problem hiding this comment.
I mean that was my point with this line, I could also remove it.
Co-authored-by: Thorbjørn Lindeijer <bjorn@lindeijer.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds instructions on how to build the project to the README.